Re: [PATCH 2/2] gpio: omap: save two lines by using devm_clk_get_prepared()

From: Matti Vaittinen
Date: Mon Dec 16 2024 - 06:15:01 EST


On 16/12/2024 13:11, Matti Vaittinen wrote:
On 16/12/2024 10:57, Sverdlin, Alexander wrote:
...

This fixes the boot as you assumed.
I suppose this should be baked in the Bartosz's original patch assumed it was dropped from the GPIO tree.

Furthermore, this seems to be a fix to a hidden problem on original code.

Just a minor clarification:
"Original code" here refers to the code before the
"gpio: omap: save two lines by using devm_clk_get_prepared()"

If the original code failed in the clk_prepare() and then deferred probe(), this same problem should have appeared, right?

Maybe consider using Fixes - tag even if this and the original change got squashed. Feel free to add a:

Yours,
-- Matti