Re: [PATCH net-next v1 3/6] net: usb: lan78xx: Use action-specific label in lan78xx_mac_reset

[Mateusz Polchlopek]

On 12/16/2024 1:09 PM, Oleksij Rempel wrote:

[...]

>   	if (ret < 0)
> -		goto done;
> +		goto exit_unlock;
>   
>   	ret = lan78xx_read_reg(dev, MAC_CR, &val);
>   	if (ret < 0)
> -		goto done;
> +		goto exit_unlock;
>   
>   	val |= MAC_CR_RST_;
>   	ret = lan78xx_write_reg(dev, MAC_CR, val);
>   	if (ret < 0)
> -		goto done;
> +		goto exit_unlock;
>   
>   	/* Wait for the reset to complete before allowing any further
>   	 * MAC register accesses otherwise the MAC may lock up.
> @@ -1621,16 +1621,16 @@ static int lan78xx_mac_reset(struct lan78xx_net *dev)
>   	do {
>   		ret = lan78xx_read_reg(dev, MAC_CR, &val);
>   		if (ret < 0)
> -			goto done;
> +			goto exit_unlock;
>   
>   		if (!(val & MAC_CR_RST_)) {
>   			ret = 0;
> -			goto done;
> +			goto exit_unlock;
>   		}
>   	} while (!time_after(jiffies, start_time + HZ));
>   
>   	ret = -ETIMEDOUT;
> -done:
> +exit_unlock:
>   	mutex_unlock(&dev->phy_mutex);
>   
>   	return ret;

Nice cleanup, now the label indicates what it does.

Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@xxxxxxxxx>