Re: [PATCH net-next v1 1/6] net: usb: lan78xx: Add error handling to lan78xx_get_regs

[Mateusz Polchlopek]

On 12/16/2024 2:19 PM, Oleksij Rempel wrote:
> On Mon, Dec 16, 2024 at 02:07:37PM +0100, Mateusz Polchlopek wrote:
> > On 12/16/2024 1:09 PM, Oleksij Rempel wrote:
> > >    	if (!netdev->phydev)
> > >    		return;
> > >    	/* Read PHY registers */
> > > -	for (j = 0; j < 32; i++, j++)
> > > -		data[i] = phy_read(netdev->phydev, j);
> > > +	for (j = 0; j < 32; i++, j++) {
> >
> > Maybe during this refactor is it worth to add some #define with
> > number of registers to be read?
>
> I prefer to remove this part. Please see patch 5

Ach, now I see that. So please forget about my comment