Re: [PATCH v5 4/6] sched_ext: Add time helpers for BPF schedulers

[Changwoo Min]

Hello,

On 24. 12. 16. 16:36, Andrea Righi wrote:
> Hi Changwoo,
>
> On Mon, Dec 16, 2024 at 12:11:42PM +0900, Changwoo Min wrote:
> > The following functions are added for BPF schedulers:
> > - vtime_delta(after, before)
> > - vtime_after(a, b)
> > - vtime_before(a, b)
> > - vtime_after_eq(a, b)
> > - vtime_before_eq(a, b)
> > - vtime_in_range(a, b, c)
> > - vtime_in_range_open(a, b, c)
>
> Considering that we sync these headers and sched examples from the scx repo
> (see https://github.com/sched-ext/scx/blob/main/scheds/sync-to-kernel.sh),
> maybe we could have a corresponding change there as well and include a link
> to the PR here (as "Link: ...").
>
> Moreover, tis particular change doesn't require to have the rest of the
> patch set applied to the kernel, so a PR can be created even now. In this
> way we don't risk to get out of sync.
>
> What do you think?

Thanks for the suggestion! As soon as there is a consensus,
I will submit a PR on the scx repo for the common.bpf.h and the
affected scx schedulers.

Regards,
Changwoo Min