Re: [PATCH v2 00/10] drm/connector: add eld_mutex to protect connector->eld
From: Maxime Ripard
Date: Mon Dec 16 2024 - 10:24:41 EST
On Mon, Dec 16, 2024 at 01:24:29PM +0200, Dmitry Baryshkov wrote:
> On Fri, Dec 06, 2024 at 11:43:03AM +0200, Dmitry Baryshkov wrote:
> > The connector->eld is accessed by the .get_eld() callback. This access
> > can collide with the drm_edid_to_eld() updating the data at the same
> > time. Add drm_connector.eld_mutex to protect the data from concurrenct
> > access.
> >
> > The individual drivers were just compile tested. I propose to merge the
> > drm_connector and bridge drivers through drm-misc, allowing other
> > maintainers either to ack merging through drm-misc or merging the
> > drm-misc into their tree and then picking up correcponding patch.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > Changes in v2:
> > - Also take the mutex in clear_eld() (Jani)
> > - Rebased on top of linux-next + drm-misc-next to solve build error
> > - Link to v1: https://lore.kernel.org/r/20241201-drm-connector-eld-mutex-v1-0-ba56a6545c03@xxxxxxxxxx
> >
> > ---
> > Dmitry Baryshkov (10):
> > drm/connector: add mutex to protect ELD from concurrent access
> > drm/bridge: anx7625: use eld_mutex to protect access to connector->eld
> > drm/bridge: ite-it66121: use eld_mutex to protect access to connector->eld
> > drm/amd/display: use eld_mutex to protect access to connector->eld
> > drm/exynos: hdmi: use eld_mutex to protect access to connector->eld
> > drm/i915/audio: use eld_mutex to protect access to connector->eld
> > drm/msm/dp: use eld_mutex to protect access to connector->eld
> > drm/radeon: use eld_mutex to protect access to connector->eld
> > drm/sti: hdmi: use eld_mutex to protect access to connector->eld
> > drm/vc4: hdmi: use eld_mutex to protect access to connector->eld
>
> Granted the lack of reviews from AMD maintainers and granted that the
> rest of the series was reviewed and acked, is it suitable to leave those
> two patches out and merge the rest through drm-misc-next?
Sounds reasonable to me
Maxime
Attachment:
signature.asc
Description: PGP signature