Re: [PATCH v2] qed: fix possible uninit pointer read in qed_mcp_nvm_info_populate()
From: Simon Horman
Date: Mon Dec 16 2024 - 11:07:41 EST
On Sun, Dec 15, 2024 at 02:17:34AM +0100, Gianfranco Trad wrote:
> Coverity reports an uninit pointer read in qed_mcp_nvm_info_populate().
> If EOPNOTSUPP is returned from qed_mcp_bist_nvm_get_num_images() ensure
> nvm_info.num_images is set to 0 to avoid possible uninit assignment
> to p_hwfn->nvm_info.image_att later on in out label.
>
> Closes: https://scan5.scan.coverity.com/#/project-view/63204/10063?selectedIssue=1636666
> Suggested-by: Simon Horman <horms@xxxxxxxxxx>
> Signed-off-by: Gianfranco Trad <gianf.trad@xxxxxxxxx>
> ---
> Notes:
> - Changes in v2: set nvm_info.num_images to 0 before goto out.
> - Link to v1: https://lore.kernel.org/all/20241211134041.65860-2-gianf.trad@xxxxxxxxx/
Thanks for the update.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>