Re: [PATCH v2 1/4] perf header: Write out even empty die_cpus_list
From: Ian Rogers
Date: Mon Dec 16 2024 - 12:05:04 EST
On Sun, Dec 15, 2024 at 5:46 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> Reading the CPU topology is tolerant to the dies_cpus_list being
> missing by using the feature's size in the data file/pipe. However,
> the feature's size is just the header size and may be
> unaligned. Making the header size aligned breaks detecting a missing
> die_cpus_list. To allow the header size to be aligned always write the
> die_cpus_lists even if empty.
>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
This change breaks the "Session topology" test on ARM with "Cpu map -
Die ID doesn't match" . One die id is -1 and the other is 0. I'll look
into addressing this in v3.
Thanks,
Ian