Re: [PATCH V3] tools/perf/tests/shell/base_probe: Enhance print_overall_results to print summary information

[Arnaldo Carvalho de Melo]

On Wed, Dec 11, 2024 at 05:33:50PM +0530, kajoljain wrote:
> On 12/6/24 19:22, Athira Rajeev wrote:
> > Here -a and -d doesn't require DWARF. Similarly there
> > are few other tests requiring DWARF. To hint the user that
> > missing dwarf could be one issue, update print_overall_results
> > to print a comment string along with summary hinting the possible
> > cause. Update test_invalid_options.sh and test_line_semantics.sh
> > to pass the info about dwarf requirement since these tests
> > failed when perf is built without DWARF. Use the check for
> > presence of dwarf with "perf check feature" and append the
> > hint message based on the result.
 
> Patch looks fine to me.
 
> Reviewed-by: kjain@xxxxxxxxxxxxx

Thanks, applied to perf-tools-next,

- Arnaldo