Re: [PATCH] staging: media: max96712: fix kernel oops when removing module

[Laurentiu Palcu]

Hi,

On Mon, Dec 16, 2024 at 06:05:51PM +0100, Ricardo Ribalda Delgado wrote:
> Hi
> 
> You probably want to add:
> diff --git a/drivers/staging/media/max96712/max96712.c
> b/drivers/staging/media/max96712/max96712.c
> index ede02e8c891c..a47f18d57325 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -418,7 +418,6 @@ static int max96712_probe(struct i2c_client *client)
>         priv->info = of_device_get_match_data(&client->dev);
> 
>         priv->client = client;
> -       i2c_set_clientdata(client, priv);
> 
>         priv->regmap = devm_regmap_init_i2c(client, &max96712_i2c_regmap);
>         if (IS_ERR(priv->regmap))
> 
> That way it will be more difficult to make the same mistake again.

Sounds good. Will fix in v2.

Thanks,
Laurentiu

> 
> Regards!