Re: [PATCH v3 3/3] nvme: handle connectivity loss in nvme_set_queue_count

From: Daniel Wagner
Date: Tue Dec 17 2024 - 03:35:32 EST


On Fri, Nov 29, 2024 at 12:10:33PM +0100, Hannes Reinecke wrote:
> > + /*
> > + * It's either a kernel error or the host observed a connection
> > + * lost. In either case it's not possible communicate with the
> > + * controller and thus enter the error code path.
> > + */
> > + if (status < 0 || status == NVME_SC_HOST_PATH_ERROR)
> > return status;
> > /*
> >
> Hmm. Maybe checking for NVME_SC_DNR, too?

if no one complains I'll update the check to:

if (status < 0 || (status > 0 && (status & NVME_STATUS_DNR)) ||
status == NVME_SC_HOST_PATH_ERROR)
return status;

okay?