Re: [PATCH net-next v1] net: stmmac: TSO: Simplify the code flow of DMA descriptor allocations
From: Paolo Abeni
Date: Tue Dec 17 2024 - 04:30:41 EST
On 12/13/24 04:00, Furong Xu wrote:
> The DMA AXI address width of DWMAC cores can be configured to
> 32-bit/40-bit/48-bit, then the format of DMA transmit descriptors
> get a little different between 32-bit and 40-bit/48-bit.
> Current driver code checks priv->dma_cap.addr64 to use certain format
> with certain configuration.
>
> This patch converts the format of DMA transmit descriptors on platforms
> that the DMA AXI address width is configured to 32-bit (as described by
> function comments of stmmac_tso_xmit() in current code) to a more generic
> format (see the updated function comments after this patch) which is
> actually already used on 40-bit/48-bit platforms to provide better
> compatibility and make code flow cleaner.
>
> Tested and verified on:
> DWMAC CORE 5.10a with 32-bit DMA AXI address width
> DWXGMAC CORE 3.20a with 40-bit DMA AXI address width
>
> Signed-off-by: Furong Xu <0x1207@xxxxxxxxx>
Makes sense to me.
Since this could potentially impact multiple versions, it would be great
if we could have a little more 3rd parties testing.
Thanks,
Paolo