Re: [PATCH v5 3/4] arm64: dts: qcom: qcs615: add venus node

[Renjiang Han]

On 12/17/2024 5:38 PM, Bryan O'Donoghue wrote:
> On 17/12/2024 09:17, Renjiang Han wrote:
> > +
> > +            video-decoder {
> > +                compatible = "venus-decoder";
> > +            };
> > +
> > +            video-encoder {
> > +                compatible = "venus-encoder";
> > +            };
>
> I gave you feedback on this in v4.
>
> Could you please provide some commentary on why you're persisting with 
> this ?
>
> - Driver configuration should not live in dts
> - A patchset exists to mitigate this
> - If you don't want to use that series, what do you propose
>   to resolve this ?
>
> Please don't just ignore feedback, either act on it or add to your 
> commit log _why_ you didn't act on it.
>
> ---
> bod

 Thanks for your review. You pointed it out correctly. As replied in v4,

 I also think your change is a good change, but your change involves many

 platforms. I am not sure if other guys have comments and when it will

 pass the review. Currently, it only refers to SC7180 and falls back

 QCS615 to SC7180. I have verified it on both SC7180 and QCS615 platforms.

 I think when your change review passes, we only need to remove the

 video-decoder and video-encoder nodes in the device tree.

--
Best Regards,
Renjiang