Re: [PATCH] ip6_tunnel: Fix uninit-value in ip6_tnl_xmit

[Mazin Al haddad]

Hi Eric,

On Tue Dec 17, 2024 at 8:42 AM +03, Eric Dumazet wrote:
> On Tue, Dec 17, 2024 at 4:09 AM Mazin Al Haddad <mazin@xxxxxxxxxxxx> wrote:
> >
> > When taking the branch with skb_realloc_headroom, pskb_expand_head is
> > called, as such, pointers referencing content within the new skb's header
> > are invalid. Currently, the assignment of hop_limit accesses the now
> > invalid pointer in the network header of this "new" skb. Fix this by
> > moving the logic to assign hop_limit earlier so that the assignment
> > references the original un-resized skb instead.
>
> Unfortunately this is not fixing anything.
>
> If the IPv6 header was in the skb head before skb_realloc_headroom()
> and/or pskb_expand_head(),
> it would be copied in the new skb head.
>
> Note how the repro is sending a packet with vlan tag (88A8 : ETH_P_8021AD)
>
> endto$packet(r0, &(0x7f0000000180)="a6bea8a120e5f8320c30ce5088a8",
> 0x12, 0x0, &(0x7f0000000140)={0x11, 0x0, r3, 0x1, 0x0, 0x6, @local},
> 0x14)
>
> Current code, using pskb_inet_may_pull() is not ready yet.
>

I understand the issue better now. Thank you for taking the time
to explain, I appreciate your time and effort.

BR,
Mazin