[PATCH] wifi: cw1200: Fix potential NULL dereference
From: Linus Walleij
Date: Tue Dec 17 2024 - 07:56:01 EST
A recent refactoring was identified by static analysis to
cause another potential NULL dereference, fix this!
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Closes: https://lore.kernel.org/r/202411271742.Xa7CNVh1-lkp@xxxxxxxxx/
Fixes: 2719a9e7156c ("wifi: cw1200: Convert to GPIO descriptors")
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
---
drivers/net/wireless/st/cw1200/cw1200_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/st/cw1200/cw1200_spi.c b/drivers/net/wireless/st/cw1200/cw1200_spi.c
index 862964a8cc8761bb412b15addef562d61811440b..52386dfb5f4aa9c1f3e12e2a4002241d9ece72ee 100644
--- a/drivers/net/wireless/st/cw1200/cw1200_spi.c
+++ b/drivers/net/wireless/st/cw1200/cw1200_spi.c
@@ -442,8 +442,8 @@ static void cw1200_spi_disconnect(struct spi_device *func)
cw1200_core_release(self->core);
self->core = NULL;
}
+ cw1200_spi_off(self, dev_get_platdata(&func->dev));
}
- cw1200_spi_off(self, dev_get_platdata(&func->dev));
}
static int __maybe_unused cw1200_spi_suspend(struct device *dev)
---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20241217-cw1200-fix-d6a722f1e68f
Best regards,
--
Linus Walleij <linus.walleij@xxxxxxxxxx>