Re: [PATCH 2/3] soc: samsung: Add a driver for Samsung SPEEDY host controller

[Markuss Broks]

Hi Markus,

On 12/14/24 4:43 PM, Markus Elfring wrote:
> …
> > SPEEDY is a proprietary 1 wire serial bus used by Samsung
> > in various devices …
> You may occasionally put more than 57 characters into text lines
> of such a change description.

But does it really matter where I break the line? For me, it just seems 
ugly no matter where I do it...

> …
> > +++ b/drivers/soc/samsung/exynos-speedy.c
> > @@ -0,0 +1,457 @@
> …
> > +static int _speedy_read(struct speedy_controller *speedy, u32 reg, u32 addr, u32 *val)
> > +{
> > +	int ret;
> > +	u32 cmd, int_ctl, int_status;
> > +
> > +	mutex_lock(&speedy->io_lock);
> …
> > +	ret = speedy_int_clear(speedy);
> > +
> > +	mutex_unlock(&speedy->io_lock);
> > +
> > +	return ret;
> > +}
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&speedy->io_lock);”?
> https://elixir.bootlin.com/linux/v6.13-rc2/source/include/linux/mutex.h#L201


I did not know such statement existed, thanks for the tip, it definitely 
helps and makes it simpler!


> Regards,
> Markus


- Markuss