Re: [PATCH] drm/rockchip: Don't change hdmi reference clock rate

From: Cristian Ciocaltea
Date: Tue Dec 17 2024 - 15:52:41 EST


On 12/17/24 10:17 PM, Derek Foreman wrote:
> The code that changes hdmi->ref_clk was accidentally copied from
> downstream code that sets a different clock. We don't actually
> want to set any clock here at all.
>
> Setting this clock incorrectly leads to incorrect timings for
> DDC, CEC, and HDCP signal generation.
>
> No Fixes listed, as the theoretical timing error in DDC appears to
> still be within tolerances and harmless - and HDCP and CEC are not
> yet supported.
>
> Signed-off-by: Derek Foreman <derek.foreman@xxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 13 -------------
> 1 file changed, 13 deletions(-)

Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>