Re: [PATCH 2/2] dt-bindings: media: imx219: Describe sensor address using the reg property

From: David Heidelberg
Date: Tue Dec 17 2024 - 16:28:23 EST


Oh, the checkpatch script keeps warning me every time I commit—I guess it needs to be addressed.

I currently use:

[diff]
srcprefix = ./
dstprefix = ./

Originally, my intention was to use:

[diff]
noprefix = true

This was to make it easier to copy-paste directly into the shell (git log -p, etc.). However, it ended up breaking too many applications. Setting srcprefix and dstprefix instead keeps everything working properly.

Is there any chance a patch allowing a ./ prefix could make it into checkpatch? What do you think, Krzysztof?

Thank you,
David

On 17/12/2024 02:40, Krzysztof Kozlowski wrote:
On Mon, Dec 16, 2024 at 09:41:51PM -0500, David Heidelberg wrote:
Use the reg property instead of text in the description.
Drop useless description of reg property.

Signed-off-by: David Heidelberg <david@xxxxxxx>
---
Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml

You are using non-standard tools to generate patches. See checkpatch
warnings.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof


--
David Heidelberg