Re: [PATCH v2] dt-bindings: mmc: atmel,hsmci: Convert to json schema

[Dharma.B]

Hi Rob,

On 17/12/24 6:13 pm, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, Dec 09, 2024 at 10:02:30AM +0530, Dharma Balasubiramani wrote:
>> Convert atmel,hsmci documentation to yaml format. The new file will inherit
>> from mmc-controller.yaml.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
>> ---
>> Changes in v2:
>> - Drop the duplicate properties in the slot node.
>> - Link to v1: https://lore.kernel.org/r/20241205-hsmci-v1-1-5a25e622dfed@xxxxxxxxxxxxx
>> ---
>>   .../devicetree/bindings/mmc/atmel,hsmci.yaml       | 110 +++++++++++++++++++++
>>   .../devicetree/bindings/mmc/atmel-hsmci.txt        |  73 --------------
>>   2 files changed, 110 insertions(+), 73 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/atmel,hsmci.yaml b/Documentation/devicetree/bindings/mmc/atmel,hsmci.yaml
>> new file mode 100644
>> index 000000000000..26686ada6288
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mmc/atmel,hsmci.yaml
>> @@ -0,0 +1,110 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mmc/atmel,hsmci.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Atmel High-Speed MultiMedia Card Interface (HSMCI)
>> +
>> +description:
>> +  The Atmel HSMCI controller provides an interface for MMC, SD, and SDIO memory
>> +  cards.
>> +
>> +maintainers:
>> +  - Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
>> +  - Aubin Constans <aubin.constans@xxxxxxxxxxxxx>
>> +
>> +allOf:
>> +  - $ref: mmc-controller.yaml
>> +
>> +properties:
>> +  compatible:
>> +    const: atmel,hsmci
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  dmas:
>> +    maxItems: 1
>> +
>> +  dma-names:
>> +    const: rxtx
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    const: mci_clk
>> +
>> +  "#address-cells":
>> +    const: 1
>> +    description: Used for slot IDs.
>> +
>> +  "#size-cells":
>> +    const: 0
>> +
>> +patternProperties:
>> +  "^slot@[0-9]+$":
>> +    type: object
>> +    description: A slot node representing an MMC, SD, or SDIO slot.
> 
> There's a schema for slots now queued for 6.14[1]. You should use that.

Sure,
I will drop these and will just add the REF to mmc-slot

  patternProperties:
    "^slot@[0-9]+$":
-    type: object
-    description: A slot node representing an MMC, SD, or SDIO slot.
-
-    allOf:
-      - $ref: mmc-controller.yaml
-
-    properties:
-      reg:
-        description: Slot ID.
-        minimum: 0
+    $ref: mmc-slot.yaml

> One issue is 'compatible' is required. Either that would have to be
> dropped as required 
How to do that?

dt_binding_check complains that mmc@f0008000: slot@0: 'compatible' is a 
required property.

If the mmc-slot yaml is a generic binding then shall we move the 
compatible to its specific binding(amlogic,meson-mx-sdio.yaml)?

or you could just add it in your .dts files.

Won't it be redundant to have it?
> 
> Rob


-- 
With Best Regards,
Dharma B.