Re: [PATCH v2] loongarch/mm: disable WUC for pgprot_writecombine as same as ioremap_wc
From: Icenowy Zheng
Date: Wed Dec 18 2024 - 01:24:21 EST
在 2024-12-18星期三的 11:24 +0800,Sui Jingfeng写道:
> Hi,
>
>
> On 2024/12/18 02:18, Shuah wrote:
> > On 12/2/24 09:23, Sui Jingfeng wrote:
> > > Hi,
> > >
> >
> > > > IIUC this is a hardware bug of 7A1000 and 7A2000, so the proper
> > > > location
> > > > of the workaround is in the bridge chip driver. Or am I
> > > > misunderstanding something?
> > > >
> > >
> > > You are misunderstanding everything and ranting like a dog.
> > >
> >
> > Sui Jingfeng,
> >
> > This is not the way to work with your fellow developers in the
> > community to express disagreements.
>
>
> I'm not expressing disagreements, but argue that the contributor
> and/or talker should provide *sufficient* hardware details and
> tests. Instead of pointless *ranting* in order to get harmful
> patch merged.
I don't think the original patch is harmful.
It changes wrong things to corect, do not break known-good things,
although I assume it will slightly harm the performance -- but I think
performance w/o correctness is just meaningless. In the perspective of
graphics, you can nearly always "enhance your performance" by sending
everything to /dev/null and pretend them to be done.
>
> The discussion completely not make scene at all.
>
>
> > I would recommend following up with an apology.
> >
>
> I will not apology to indecent contributors and/or maintainers
> like this, never.
>
>
> > thanks,
> > -- Shuah
> >
> >
> >
> >
> >