Re: [PATCH v3 2/2] dt-bindings: usb: ptn5110: add TCPC properties
From: Krzysztof Kozlowski
Date: Wed Dec 18 2024 - 04:05:13 EST
On 18/12/2024 09:04, Krzysztof Kozlowski wrote:
>> interrupts:
>> maxItems: 1
>>
>> + TX_BUF_BYTE_x_hidden:
>
> Follow DTS coding style.
>
>> + description:
>> + When set, TX_BUF_BYTE_x can only be accessed through
>> + I2C_WRITE_BYTE_COUNT.
> You described the desired Linux feature or behavior, not the actual
> hardware. The bindings are about the latter, so instead you need to
> rephrase the property and its description to match actual hardware
> capabilities/features/configuration etc.
I forgot: missing vendor prefix, missing type. Please see how other
bindings are written. example-schema is also good to start with.
Best regards,
Krzysztof