Re: [PATCH 2/2] kbuild: Add option to fail build on vmlinux objtool issues

From: Josh Poimboeuf
Date: Wed Dec 18 2024 - 04:11:48 EST


On Mon, Dec 16, 2024 at 11:00:58AM +0100, Brendan Jackman wrote:
> On Sat, 14 Dec 2024 at 01:52, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > Note that *any* objtool warning has a good change of being a major bug
> > in the kernel or compiler which could result in crashing the kernel or
> > breaking the livepatch consistency model. So the option shouldn't be
> > restricted to noinstr builds only. In which case it should be called
> > CONFIG_OBJTOOL_WERROR, analagous to CONFIG_WERROR.
>
> Sure, sounds good too.
>
> Just to make sure I'm on the same page - are you saying I should add
> the flag to $(objtool-args-y) instead of $(vmlinux-objtool-args-y)?

Yeah, that should do it.

--
Josh