Re: [ovs-dev] [PATCH net] selftests: openvswitch: fix tcpdump execution

[Eelco Chaudron]

On 17 Dec 2024, at 22:16, Adrian Moreno wrote:

> Fix the way tcpdump is executed by:
> - Using the right variable for the namespace. Currently the use of the
>   empty "ns" makes the command fail.
> - Waiting until it starts to capture to ensure the interesting traffic
>   is caught on slow systems.
> - Using line-buffered output to ensure logs are available when the test
>   is paused with "-p". Otherwise the last chunk of data might only be
>   written when tcpdump is killed.
>
> Fixes: 74cc26f416b9 ("selftests: openvswitch: add interface support")
> Signed-off-by: Adrian Moreno <amorenoz@xxxxxxxxxx>

Thank for fixing this, the change looks good to me.

Acked-by: Eelco Chaudron <echaudro@xxxxxxxxxx>