Re: [PATCH net] xfrm: Rewrite key length conversion to avoid overflows

From: Herbert Xu
Date: Wed Dec 18 2024 - 06:59:36 EST


On Wed, Dec 18, 2024 at 01:54:38PM +0300, Dan Carpenter wrote:
>
> The length is capped in verify_one_alg() type functions:
>
> if (nla_len(rt) < (int)xfrm_alg_len(algp)) {
>
> nla_len() is a USHRT_MAX so the rounded value can't be higher than that.

Good catch. I hope a similar limit applies for af_key?

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt