Re: drivers/thunderbolt/debugfs.c:532:5-33: opportunity for str_yes_no(supports_software ( margining )) (fwd)
From: Mika Westerberg
Date: Wed Dec 18 2024 - 07:31:28 EST
Hi Julia,
On Tue, Dec 17, 2024 at 09:45:01AM +0100, Julia Lawall wrote:
>
>
> ---------- Forwarded message ----------
> Date: Tue, 17 Dec 2024 16:26:31 +0800
> From: kernel test robot <lkp@xxxxxxxxx>
> To: oe-kbuild@xxxxxxxxxxxxxxx
> Cc: lkp@xxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxxx>
> Subject: drivers/thunderbolt/debugfs.c:532:5-33: opportunity for
> str_yes_no(supports_software ( margining ))
>
> BCC: lkp@xxxxxxxxx
> CC: oe-kbuild-all@xxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> TO: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: f44d154d6e3d633d4c49a5d6aed8a0e4684ae25e
> commit: ec6f888ed08aeceaebfdd7d344ae0cd91a1b9a1b thunderbolt: Split out margining from USB4 port
> date: 6 months ago
> :::::: branch date: 14 hours ago
> :::::: commit date: 6 months ago
> config: loongarch-randconfig-r061-20241217 (https://download.01.org/0day-ci/archive/20241217/202412171648.LGwq0U3d-lkp@xxxxxxxxx/config)
> compiler: loongarch64-linux-gcc (GCC) 14.2.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Reported-by: Julia Lawall <julia.lawall@xxxxxxxx>
> | Closes: https://lore.kernel.org/r/202412171648.LGwq0U3d-lkp@xxxxxxxxx/
>
> cocci warnings: (new ones prefixed by >>)
> drivers/thunderbolt/debugfs.c:544:4-25: opportunity for str_yes_no(both_lanes ( margining ))
> >> drivers/thunderbolt/debugfs.c:532:5-33: opportunity for str_yes_no(supports_software ( margining ))
Definitely makes sense. Would you want to make a patch for it?