Re: [PATCH v2] loongarch/mm: disable WUC for pgprot_writecombine as same as ioremap_wc

[Icenowy Zheng]

在 2024-12-18星期三的 18:05 +0800，Sui Jingfeng写道：
> Hi,
> 
> 
> On 2024/12/18 14:23, Icenowy Zheng wrote:
> > 在 2024-12-18星期三的 11:24 +0800，Sui Jingfeng写道：
> > > Hi,
> > > 
> > > 
> > > On 2024/12/18 02:18, Shuah wrote:
> > > > On 12/2/24 09:23, Sui Jingfeng wrote:
> > > > > Hi,
> > > > > 
> > > > > > IIUC this is a hardware bug of 7A1000 and 7A2000, so the
> > > > > > proper
> > > > > > location
> > > > > > of the workaround is in the bridge chip driver.  Or am I
> > > > > > misunderstanding something?
> > > > > > 
> > > > > You are misunderstanding everything and ranting like a dog.
> > > > > 
> > > > Sui Jingfeng,
> > > > 
> > > > This is not the way to work with your fellow developers in the
> > > > community to express disagreements.
> > > 
> > > I'm not expressing disagreements, but argue that the contributor
> > > and/or talker should provide *sufficient* hardware details and
> > > tests. Instead of pointless *ranting* in order to get harmful
> > > patch merged.
> > I don't think the original patch is harmful.
> > 
> 
> I have told you countless times, that is, disabling Write-Combine
> made the performance of BMC graphics(drm/ast) decrease dramatically.

So do the ast driver have any kind of command queues that needs to be
read by the card and executed? If it has, I assume it will break like
amdgpu/radeon if this is utilized (I remember ast has some 2D accel);
if it does not have, then maybe you can add an architecture-specific
pgprot type (e.g. pgprot_wuc), see how pgprot_noncached_wc is defined
for PowerPC or pgprot_device is defined for ARM64 -- in fact you may
find another architecture that have some page attribute that behave
like WUC on LongArch; and then utilize the newly introduced pgprot type
in drm/ast, instead of using WUC as pgprot_writecombine, which do not
exactly match (usual driver expect an ARM-like behavior of
pgprot_combine, I assume).

> And downstream Loongson developer really dislike related patch,
> and asking for solutions to me.
> 
> 
> > > The discussion completely not make scene at all.
> > > 
> > > 
> > > > I would recommend following up with an apology.
> > > > 
> > > I will not apology to indecent contributors and/or maintainers
> > > like this, never.
> > > 
> > > 
> > > > thanks,
> > > > -- Shuah
> > > > 
> > > > 
> > > > 
> > > > 
> > > >