Re: [PATCH 1/7] dt-bindings: Add support for export-symbols node

From: Herve Codina
Date: Wed Dec 18 2024 - 08:08:13 EST


Hi Rob, Krzysztof, Conor,

On Mon, 09 Dec 2024 10:26:26 -0600
"Rob Herring (Arm)" <robh@xxxxxxxxxx> wrote:

>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> compress: size (5) error for type phandle
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.example.dtb: uimage@100000: compress: b'lzma\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'
> from schema $id: http://devicetree.org/schemas/dt-core.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241209151830.95723-2-herve.codina@xxxxxxxxxxx
>

I am bothered with this issue and I can't see what's wrong with my binding
export-symbols.yaml and why it has impacts on other binding such as the
example in fixed-partitions.yaml.

Can you help me in understanding what I missed that leads to this behavior.

The idea in export-symbols.yaml was:
- Constraint the name of the node to be 'export-symbols' with:
properties:
$nodename:
const: export-symbols

- Constraint properties in the node to be in the form
'label_name = <phandle>;'
Many properties of this form are allowed.

- Do not allow any other kind of properties.

I thought that only bindings referencing export-symbols.yaml or bindings
using the 'export-symbols' node name would have been impacted but it seems
the it is not the case.

Best regards,
Hervé