Re: [PATCH v7 0/5] Add pinctrl support for mt7988

[AngeloGioacchino Del Regno]

Il 17/12/24 09:54, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> This series adds pinctrl driver, dt-bindings and dts node for pinctrl
> on mediatek mt7988 SoC.
>
> changes in v7:
> - add const for pins and mtk_pin_soc as suggested by Christophe JAILLET in v5
> - left angelos RB because of minor change (hope this is right)

It's fine, I re-reviewed it and it's good (actually, better!) :-)

Cheers,
Angelo

> changes in v6:
> - some fixes to binding
> - changed title and fixed typo in bpi-r4 patch
> - added RB's
>
> changes in v5:
> - rebased to 6.13-rc1
> - moved dt nodes with mutliple options to BPI-R4 board
> - changes suggested by angelo in v4
> - changed example in binding and dt node to not using const MTK_DRIVE_8mA
>
> changes in v4:
> - fixed fixed string binding error
>
> changes in v3:
> - rebase on rafals dts patches
> - update binding to have mux subnode as fixed string and conf with optional suffix
>
> changes in v2:
>    binding:
>    - drop gpio-cells description
>    - move ref in mux subnode up
>    - order uart-functions alphanumeric and fix typo
>    dts:
>    - fix indentation of reg-values
>
> Daniel Golle (2):
>    pinctrl: mediatek: add support for MTK_PULL_PD_TYPE
>    pinctrl: mediatek: add MT7988 pinctrl driver
>
> Frank Wunderlich (3):
>    dt-bindings: pinctrl: add binding for MT7988 SoC
>    arm64: dts: mediatek: mt7988: Add pinctrl support
>    arm64: dts: mediatek: mt7988a-bpi-r4: Add pinctrl subnodes for bpi-r4
>
>   .../pinctrl/mediatek,mt7988-pinctrl.yaml      |  575 ++++++
>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  |  189 ++
>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi     |   54 +
>   drivers/pinctrl/mediatek/Kconfig              |    7 +
>   drivers/pinctrl/mediatek/Makefile             |    1 +
>   drivers/pinctrl/mediatek/pinctrl-mt7988.c     | 1556 +++++++++++++++++
>   .../pinctrl/mediatek/pinctrl-mtk-common-v2.c  |   73 +-
>   .../pinctrl/mediatek/pinctrl-mtk-common-v2.h  |    1 +
>   8 files changed, 2445 insertions(+), 11 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt7988-pinctrl.yaml
>   create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt7988.c