Re: [PATCH V3] scsi: ufs: qcom: Enable UFS Shared ICE Feature

[Ram Kumar Dwivedi]

On 17-Dec-24 9:16 PM, Bart Van Assche wrote:
> On 12/17/24 6:40 AM, Ram Kumar Dwivedi wrote:
>> +    unsigned int val[4] = { NUM_RX_R1W0, NUM_TX_R0W1, NUM_RX_R1W1, NUM_TX_R1W1 };
>> +    unsigned int config;
>> +
>> +    if (!is_ice_config_supported(host))
>> +        return;
>> +
>> +    config = val[0] | (val[1] << 8) | (val[2] << 16) | (val[3] << 24);
> 
> Has it been considered to change the data type of val[] from unsigned int into u8 or uint8_t? That would allow to use get_unaligned_le32() instead of the above bit-shift expression. Additionally, why has 'config' been declared as 'int' instead of 'u32'?
>
Hi Bart, 
Thanks for review. We have addressed your comment in latest patchset.

Thanks,
Ram.

> Thanks,
> 
> Bart.