Re: [Intel-wired-lan] [net-next] ice: expose non_eop_descs to ethtool

[Alexander Lobakin]

From: Jonathan Maxwell <jmaxwell37@xxxxxxxxx>
Date: Wed, 18 Dec 2024 09:13:00 +1100

> On Wed, Dec 18, 2024 at 1:49 AM Alexander Lobakin
> <aleksander.lobakin@xxxxxxxxx> wrote:
>>
>> From: Jon Maxwell <jmaxwell37@xxxxxxxxx>
>> Date: Tue, 17 Dec 2024 10:48:50 +1100
>>
>>> The ixgbe driver exposes non_eop_descs to ethtool. Do the same for ice.
>>
>> Only due to that?
>> Why would we need it in the first place?
>>
> 
> Not just that. We had a critical ice bug we were diagnosing and saw this
> counter in the Vmcore. When we set up a reproducer we needed to check that
> counter was incrementing. I added this patch to do that and thought that
> it may aid trouble-shooting in the future as well so I sent it upstream.

ethtool -S is slowly getting deprecated, I wouldn't encourage exporting
more new stats. The best thing you could do is to add such field to the
generic per-queue stats and implement them in ice.

> 
> Regards
> 
> Jon

Thanks,
Olek