Re: lock in vsprintf(): was: Re: [PATCH] of: Add printf '%pOFm' for generating modalias

From: Steven Rostedt
Date: Wed Dec 18 2024 - 11:31:31 EST


On Wed, 18 Dec 2024 13:27:39 +0100
Petr Mladek <pmladek@xxxxxxxx> wrote:

> But this would happen only when the last reference is released
> when formatting the string which is kind of corner case.
>
> As I said, I think that taking lock in vsprintf() formats is highly
> unexpected and thus a way to hell.
>
> What do others think, please?

We already can take locks from printk formats.

https://lore.kernel.org/all/20241120102602.3e17f2d5@xxxxxxxxxxxxxxxxxx/

At least when SELinux is enabled.

But that may be an SELinux issue and not a printk one.

-- Steve