Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature

[Bart Van Assche]

On 12/18/24 7:11 AM, Ram Kumar Dwivedi wrote:
> +static void ufs_qcom_config_ice_allocator(struct ufs_qcom_host *host)
> +{
> +	struct ufs_hba *hba = host->hba;
> +	uint8_t val[4] = { NUM_RX_R1W0, NUM_TX_R0W1, NUM_RX_R1W1, NUM_TX_R1W1 };

This array can be declared 'static const', isn't it?

> +	u32 config;
> +
> +	if (!is_ice_config_supported(host))
> +		return;
> +
> +	config = val[0] | (val[1] << 8) | (val[2] << 16) | (val[3] << 24);

Isn't this is an open-coded version of get_unaligned_le32()?

Thanks,

Bart.