Re: [PATCH RFC v2 4/4] block/mq-deadline: introduce min_async_depth

From: Bart Van Assche
Date: Wed Dec 18 2024 - 13:07:29 EST


On 12/17/24 5:12 PM, Yu Kuai wrote:
dd->async_depth is initialized to 0 now, functionally I think
it's the same as q->nr_requests. And I do explain this in commit
message, maybe it's not clear?

It would be good to add a comment in the source code that explains that
__blk_mq_get_tag() does not restrict tag allocation if dd->async_depth
is zero because that causes data->shallow_depth to be zero.

Thanks,

Bart.