Re: [PATCH] kunit: platform: Resolve 'struct completion' warning

[David Gow]

On Sat, 14 Dec 2024 at 02:09, Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
>
> If the <kunit/platform_device.h> header is included in a test without
> certain other headers, it produces compiler warnings like:
>
> In file included from [...]
> ../include/kunit/platform_device.h:15:57: warning: ‘struct completion’
> declared inside parameter list will not be visible outside of this
> definition or declaration
>    15 |                                                  struct completion *x);
>       |                                                         ^~~~~~~~~~
>
> Add a 'struct completion' forward declaration to resolve this.
>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
> I'm not bothering with a Fixes tag, since this only shows up with new
> tests I'm writing.
>

Nice catch, thanks!

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature