Re: [PATCH v3 0/4] Migrate PCI Endpoint Subsystem tests to Kselftest
From: Niklas Cassel
Date: Thu Dec 19 2024 - 09:31:49 EST
On Thu, Dec 19, 2024 at 09:01:12AM +0900, Krzysztof Wilczyński wrote:
> Hello,
>
> > This series carries forward the effort to add Kselftest for PCI Endpoint
> > Subsystem started by Aman Gupta [1] a while ago. I reworked the initial version
> > based on another patch that fixes the return values of IOCTLs in
> > pci_endpoint_test driver and did many cleanups. Since the resulting work
> > modified the initial version substantially, I took over the authorship.
> >
> > This series also incorporates the review comment by Shuah Khan [2] to move the
> > existing tests from 'tools/pci' to 'tools/testing/kselftest/pci_endpoint' before
> > migrating to Kselftest framework. I made sure that the tests are executable in
> > each commit and updated documentation accordingly.
> >
> > NOTE: Patch 1 is strictly not related to this series, but necessary to execute
> > Kselftests with Qualcomm Endpoint devices. So this can be merged separately.
>
> Applied to selftests, thank you!
>
> [01/04] PCI: qcom-ep: Mark BAR0/BAR2 as 64bit BARs and BAR1/BAR3 as RESERVED
> https://git.kernel.org/pci/pci/c/71ae1c3a342c
>
> [02/04] misc: pci_endpoint_test: Fix the return value of IOCTL
> https://git.kernel.org/pci/pci/c/7908208a2f6a
>
> [03/04] selftests: Move PCI Endpoint tests from tools/pci to Kselftests
> https://git.kernel.org/pci/pci/c/5c892b60e4c6
>
> [04/04] selftests: pci_endpoint: Migrate to Kselftest framework
> https://git.kernel.org/pci/pci/c/62f966e676b5
>
> Krzysztof
I'm a bit surprised that this series was picked up,
since as you could see earlier in this same thread:
https://lore.kernel.org/linux-pci/20241219000112.GE1444967@rocinante/T/#m7bb0e624a4bf88f5cc13dc3804972c4fa9a79bcd
Mani suggested that my patch (which conflicts with this),
should be picked up first.
Is there a reason for the sudden chance of plans?
Please advice on how to proceed.
Kind regards,
Niklas