Re: [PATCH] gpio: pca953x: log an error when failing to get the reset GPIO

[Bartosz Golaszewski]

On Thu, Dec 19, 2024 at 10:39 AM Luca Ceresoli
<luca.ceresoli@xxxxxxxxxxx> wrote:
>
> When the dirver fails getting this GPIO, it fails silently. Log an error
> message to make debugging a lot easier by just reading dmesg.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
> ---
>  drivers/gpio/gpio-pca953x.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 272febc3230e90baf370811f498383b9fb12cc6f..be4c9981ebc404ad5c1e1b0ba9f9f948122de462 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -1088,7 +1088,8 @@ static int pca953x_probe(struct i2c_client *client)
>                  */
>                 reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
>                 if (IS_ERR(reset_gpio))
> -                       return PTR_ERR(reset_gpio);
> +                       return dev_err_probe(dev, PTR_ERR(reset_gpio),
> +                                            "Failed to get reset gpio\n");
>         }
>
>         chip->client = client;
>
> ---

Fixes: and Cc: stable tags?

Bart