Re: [PATCH 0/3] staging: media: max96712: a few, mainly cosmetic, changes

[Niklas Söderlund]

Hello Laurentiu,

On 2024-12-19 17:06:40 +0200, Laurentiu Palcu wrote:
> Hi,
> 
> This is in preparation for bringing our downstream max96724 work into
> the max96712 driver. The changes in this patch-set are mainly cosmetic
> to increase readability, with one exception related to the PCLK debug
> register which appears to exist in MAX96724 as well(see VPG section in
> users guide [1]).
> 
> Unfortunately, I couldn't find any max96712 reference manual anywhere to
> make sure the registers match between the 2 chips, nor I have a max96712
> to test with.

I have tested this series with both MAX96712 and MAX96724 and I can 
capture the test patterns correctly. For the series,

Tested-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> 
> However, since the max96724 compatible was added here, according to the
> commit
> 
> 6c872b782ae ("media: staging: max96712: Add support for MAX96724")
> 
> the chips are "almost identical". So, I used max96724 register and
> field descriptions instead. Someone with a max96712 RM may want to
> double-check though.
> 
> Thanks,
> Laurentiu
> 
> [1] https://www.analog.com/media/en/technical-documentation/user-guides/max96724fr-user-guide.pdf
> 
> Laurentiu Palcu (3):
>   staging: media: max96712: fix typo
>   staging: media: max96712: enable extra debug register for max96724
>   staging: media: max96712: add some register and field definitions
> 
>  drivers/staging/media/max96712/max96712.c | 210 +++++++++++++++++-----
>  1 file changed, 165 insertions(+), 45 deletions(-)
> 
> -- 
> 2.44.1
> 

-- 
Kind Regards,
Niklas Söderlund