Re: [PATCH v5 0/7] ipu6: get rid of all the IS_ENABLED(CONFIG_ACPI)

[Rafael J. Wysocki]

On Mon, Dec 16, 2024 at 10:17 PM Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote:
>
> We want to be able to compile_test the ipu6 driver in situations with
> !ACPI.
>
> In order to do this we had to add some conditional #ifs, which lead to
> false positives on the static analysers.
>
> Let's implement some helpers when !ACPI in the acpi headers to make the
> code more easier to maintain.
>
> To: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> To: Len Brown <lenb@xxxxxxxxxx>
> To: Robert Moore <robert.moore@xxxxxxxxx>
> To: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-acpi@xxxxxxxxxxxxxxx
> Cc: acpica-devel@xxxxxxxxxxxxxxx
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
>
> Changes in v5:
> - Remove Fixes tag
> - redefine acpi_get_physical_device_location() to return bool
> - Link to v4: https://lore.kernel.org/r/20241211-fix-ipu-v4-0-4102e97aceb6@xxxxxxxxxxxx
>
> Changes in v4 (Thanks Sakari & Mauro):
> - Squash the two ipu changes and merge everything via ACPI
> - Space after ;
> - move acpi_device_handle to avoid fwd declaration.
> - Link to v3: https://lore.kernel.org/r/20241210-fix-ipu-v3-0-00e409c84a6c@xxxxxxxxxxxx
>
> Changes in v3:
> - Prefer static inlines to macros (Thanks Rafael).
> - Link to v2: https://lore.kernel.org/r/20241122-fix-ipu-v2-0-bba65856e9ff@xxxxxxxxxxxx
>
> Changes in v2:
> - Add helpers in acpi to avoid conditional compilation
> - Link to v1: https://lore.kernel.org/r/20241122-fix-ipu-v1-1-246e254cb77c@xxxxxxxxxxxx
>
> ---
> Ricardo Ribalda (7):
>       ACPI: bus: change the prototype for acpi_get_physical_device_location
>       ACPI: bus: implement for_each_acpi_dev_match when !ACPI
>       ACPI: bus: implement acpi_get_physical_device_location when !ACPI
>       ACPI: header: implement acpi_device_handle when !ACPI
>       ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI
>       ACPI: bus: implement acpi_device_hid when !ACPI
>       media: ipu-bridge: Remove unneeded conditional compilations
>
>  drivers/acpi/mipi-disco-img.c        |  3 +--
>  drivers/acpi/scan.c                  |  4 +---
>  drivers/acpi/utils.c                 |  7 +++----
>  drivers/base/physical_location.c     |  4 +---
>  drivers/media/pci/intel/ipu-bridge.c | 29 ++++-------------------------
>  drivers/usb/core/usb-acpi.c          |  3 +--
>  include/acpi/acpi_bus.h              | 23 ++++++++++++++++++++---
>  include/linux/acpi.h                 |  5 +++++
>  8 files changed, 36 insertions(+), 42 deletions(-)
> ---

Series applied as 6.14 material, thanks!