Re: [PATCH v4] drm/bridge:anx7625: Update HDCP content status

From: Dmitry Baryshkov
Date: Thu Dec 19 2024 - 19:24:44 EST


On Thu, Dec 19, 2024 at 03:03:29PM +0800, Xin Ji wrote:
> When user enabled HDCP feature, userspace will set HDCP content
> to DRM_MODE_CONTENT_PROTECTION_DESIRED. Next, anx7625 will update
> HDCP content to DRM_MODE_CONTENT_PROTECTION_ENABLED if down stream
> support HDCP feature.
>
> As anx7625 bridge IC will be power down after call .atomic_disable(),
> then all HDCP status will be lost on chip. So we should reestablish
> HDCP again in .atomic_enable(), and update hdcp content to DESIRE if
> current HDCP content is ENABLE in .atomic_disable().
>
> v4:
> - Change HDCP content value to DESIRED if HDCP status is ENABLE in bridge
> interface .atomic_enable().
>
> v3:
> - Move hdcp content value checking from bridge interface
> .atomic_check() to .atomic_enable()
>
> v2:
> - Add more details in commit message
>
> Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 73 +++++++++--------------
> 1 file changed, 29 insertions(+), 44 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Thank you for going through the reviews and explaining the issue!

--
With best wishes
Dmitry