Re: [PATCH v10 21/24] x86/resctrl: Configure mbm_cntr_assign mode if supported

[Reinette Chatre]

Hi Babu,

On 12/12/24 12:15 PM, Babu Moger wrote:
> Configure mbm_cntr_assign on AMD. 'mbm_cntr_assign' mode in AMD is ABMC
> (Assignable Bandwidth Monitoring Counters). It is enabled by default when
> supported on the system.

Needs imperative "Enable mbm_cntr_assign mode ..."

> 
> Ensure that the ABMC is updated on all logical processors in the resctrl
> domain.

Needs imperative (for example) "Update the assignable counter mode .."


Please distinguish how it is the architecture that decides what the
default mode should be. resctrl's part is to ensure that architecture
gets opportunity to configure every logical processor as it comes online.

Reinette