Re: [PATCH 4/8] pwm: max7360: Add MAX7360 PWM support

From: Uwe Kleine-König
Date: Fri Dec 20 2024 - 00:51:29 EST


Hello again,

On Thu, Dec 19, 2024 at 05:21:21PM +0100, mathieu.dubois-briand@xxxxxxxxxxx wrote:
> diff --git a/drivers/pwm/pwm-max7360.c b/drivers/pwm/pwm-max7360.c
> new file mode 100644
> index 000000000000..b1cde3e86864
> --- /dev/null
> +++ b/drivers/pwm/pwm-max7360.c
> @@ -0,0 +1,173 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright 2024 Bootlin
> + *

I forgot: Please also add a paragraph here describing the relevant
features here in the format that several other drivers use. Such that

sed -rn '/Limitations:/,/\*\/?$/p' drivers/pwm/*.c

emits it. Relevant are at least:

- Only supports normal polarity

- How does it behave on disable? (Constant low? Freeze at the level
where it just happens to be? High-Z?)

- How does it behave on reconfiguration? (counter reset? Mixed output
possible?

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature