Re: [PATCH RESEND] VMCI: remove unused ioctl definitions

[Vishnu Dasa]

On Thu, Dec 19, 2024 at 3:30 PM Alyssa Ross <hi@xxxxxxxxx> wrote:
>
> IOCTL_VMCI_SOCKETS_VERSION and IOCTL_VMCI_SOCKETS_GET_AF_VALUE were
> never implemented, because VSOCK ended up being implemented as a
> generic mechanism with a static AF value.  Likewise,
> IOCTL_VMCI_SOCKETS_GET_LOCAL_CID ended up being implemented as
> IOCTL_VM_SOCKETS_GET_LOCAL_CID.
>
> This isn't a UAPI header, so it should be fine to remove the unused
> values.  I've left a comment noting IOCTL_VM_SOCKETS_GET_LOCAL_CID is
> in the VMCI range to avoid unintentional reuse.
>
> Signed-off-by: Alyssa Ross <hi@xxxxxxxxx>

Acked-by: Vishnu Dasa <vishnu.dasa@xxxxxxxxxxxx>

> ---
> Hi misc maintainers!  I'm sending this version of the patch to you
> because the VMWare VMCI maintainers don't seem to be around any more.
> The last message on lore from either of them was in May.  Since then,
> I've submitted this patch twice, and haven't heard anything in response.
>
>  include/linux/vmw_vmci_defs.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/vmw_vmci_defs.h b/include/linux/vmw_vmci_defs.h
> index 6fb663b36f72..c2df94696593 100644
> --- a/include/linux/vmw_vmci_defs.h
> +++ b/include/linux/vmw_vmci_defs.h
> @@ -453,9 +453,7 @@ enum {
>  #define IOCTL_VMCI_CTX_GET_CPT_STATE           _IO(7, 0xb1)
>  #define IOCTL_VMCI_CTX_SET_CPT_STATE           _IO(7, 0xb2)
>  #define IOCTL_VMCI_GET_CONTEXT_ID              _IO(7, 0xb3)
> -#define IOCTL_VMCI_SOCKETS_VERSION             _IO(7, 0xb4)
> -#define IOCTL_VMCI_SOCKETS_GET_AF_VALUE                _IO(7, 0xb8)
> -#define IOCTL_VMCI_SOCKETS_GET_LOCAL_CID       _IO(7, 0xb9)
> +/*IOCTL_VM_SOCKETS_GET_LOCAL_CID               _IO(7, 0xb9)*/
>  #define IOCTL_VMCI_SET_NOTIFY                  _IO(7, 0xcb)    /* 1995 */
>  /*IOCTL_VMMON_START                            _IO(7, 0xd1)*/  /* 2001 */
>
>
> base-commit: c33ffdb70cc6df4105160f991288e7d2567d7ffa
> --
> 2.45.1
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature