Re: [PATCH v2 1/1] lib: Remove dead code

[Greg KH]

On Fri, Dec 20, 2024 at 09:44:31AM +0100, Ariel Otilibili-Anieli wrote:
> On Friday, December 20, 2024 08:09 CET, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Thu, Dec 19, 2024 at 11:45:01PM +0100, Ariel Otilibili wrote:
> > > This is a follow up from a discussion in Xen:
> > > 
> > > The if-statement tests `res` is non-zero; meaning the case zero is never reached.
> > > 
> > > Link: https://lore.kernel.org/all/7587b503-b2ca-4476-8dc9-e9683d4ca5f0@xxxxxxxx/
> > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > > Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> > > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@xxxxxxxxxx>
> > > --
> > > Cc: stable@xxxxxxxxxxxxxxx
> > 
> > Why is "removing dead code" a stable kernel thing?
> 
> Hello Greg,
> 
> It is what I understood from the process:
> 
> "Attaching a Fixes: tag does not subvert the stable kernel rules process nor the requirement to Cc: stable@xxxxxxxxxxxxxxx on all stable patch candidates." [1]
> 
> Does my understanding make sense?

I'm confused, what are you expecting to happen here?  Why is this even
marked as a "fix"?

> [1] https://docs.kernel.org/process/submitting-patches.html

Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

for the stable kernel rules.

Again, you have a "cc: stable@..." in your patch, why?

thanks,

greg k-h