Re: [PATCH for-next] selftests/alsa: Fix circular dependency involving global-timer

[Takashi Iwai]

On Wed, 18 Dec 2024 03:59:31 +0100,
Li Zhijian wrote:
> 
> The pattern rule `$(OUTPUT)/%: %.c` inadvertently included a circular
> dependency on the global-timer target due to its inclusion in
> $(TEST_GEN_PROGS_EXTENDED). This resulted in a circular dependency
> warning during the build process.
> 
> To resolve this, the dependency on $(TEST_GEN_PROGS_EXTENDED) has been
> replaced with an explicit dependency on $(OUTPUT)/libatest.so. This change
> ensures that libatest.so is built before any other targets that require it,
> without creating a circular dependency.
> 
> This fix addresses the following warning:
> 
> make[4]: Entering directory 'tools/testing/selftests/alsa'
> make[4]: Circular default_modconfig/kselftest/alsa/global-timer <- default_modconfig/kselftest/alsa/global-timer dependency dropped.
> make[4]: Nothing to be done for 'all'.
> make[4]: Leaving directory 'tools/testing/selftests/alsa'
> 
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxxx>
> Cc: Shuah Khan <shuah@xxxxxxxxxx>
> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>

Applied now.  Thanks.


Takashi