Re: [PATCH 6/6] sched_ext: Move built-in idle CPU selection policy to a separate file

From: Andrea Righi
Date: Fri Dec 20 2024 - 09:59:18 EST


On Fri, Dec 20, 2024 at 06:53:28AM -0800, Yury Norov wrote:
> On Tue, Dec 17, 2024 at 10:32:31AM +0100, Andrea Righi wrote:
> > As ext.c is becoming quite large, move the idle CPU selection policy
> > to a separate file (ext_idle.c) for better code readability.
> >
> > No functional change, this is purely code reorganization.
> >
> > Suggested-by: Yury Norov <yury.norov@xxxxxxxxx>
> > Signed-off-by: Andrea Righi <arighi@xxxxxxxxxx>
>
> I think it should be a preparation patch at the beginning of the
> series. The one major downside of patches of that sort is that when
> moving code, you wipe git history. If you have to do that, you need
> to move code before doing the work, such that at least your updates
> will be accessible to git blame.

Right, I've already moved this at the beginning. :)

I'm re-running the usual set of tests and will likely send a new patch set
if everything looks good.

Thanks!
-Andrea