Re: [PATCH] usbip: tools: update return status when failed

[Shuah Khan]

On 10/22/24 01:58, Hongren Zheng wrote:
> On Tue, Oct 22, 2024 at 02:48:56PM +0800, Zongmin Zhou wrote:
> > From: Zongmin Zhou <zhouzongmin@xxxxxxxxxx>
> >
> > Have to set "ret" before return when found a invalid port.
> >
> > Signed-off-by: Zongmin Zhou <zhouzongmin@xxxxxxxxxx>
>
> Reviewed-by: Hongren Zheng <i@xxxxxxxxxxx>
>
> > ---
> >   tools/usb/usbip/src/usbip_detach.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c
> > index b29101986b5a..6b78d4a81e95 100644
> > --- a/tools/usb/usbip/src/usbip_detach.c
> > +++ b/tools/usb/usbip/src/usbip_detach.c
> > @@ -68,6 +68,7 @@ static int detach_port(char *port)
> >   	}
> >   
> >   	if (!found) {
> > +		ret = -1;
> >   		err("Invalid port %s > maxports %d",
> >   			port, vhci_driver->nports);
> >   		goto call_driver_close;
> > --
> > 2.34.1

Looks like I missed this one. Sorry for the delay on this.

Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

Greg, Please pick this one as well.

thanks,
-- Shuah