Re: [PATCH v4 17/25] memremap: Add is_device_dax_page() and is_fsdax_page() helpers

From: David Hildenbrand
Date: Fri Dec 20 2024 - 13:39:56 EST


On 17.12.24 06:13, Alistair Popple wrote:
Add helpers to determine if a page or folio is a device dax or fs dax
page or folio.

... why is it "device_dax" but "fsdax" ? In particular because you wrote "fs dax" above.

I see "fsdax" getting used in some functions. But then, people usually say "devdax".

I'm fine either way (could be cleaned up later), just wondering about that slight "inconsistency".

So whatever you think is best, feel free to add

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb