Re: [PATCH v1 0/3] Prefer evsel over evsel->core.idx

[Ian Rogers]

On Fri, Dec 13, 2024 at 4:13 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> On Thu, Nov 14, 2024 at 03:07:10PM -0800, Ian Rogers wrote:
> > James Clark's patches fixing evsel->core.idx [1] reminded me that we
> > pass the int value around unnecessarily. Passing the evsel avoids
> > issues if the evlist is reordered but paired with sanitizers we can
> > also know when something is used when it shouldn't be. These patches
> > do some initial work reducing the use of evsel->core.idx or reducing
> > the API to pass evsels and not their interior index.
> >
> > [1] https://lore.kernel.org/lkml/20241114160450.295844-2-james.clark@xxxxxxxxxx/
> >
> > Ian Rogers (3):
> >   perf stream: Use evsel rather than evsel->idx
> >   perf values: Use evsel rather than evsel->idx
> >   perf annotate: Prefer passing evsel to evsel->core.idx

Ping.

Reviewed-by: Namhyung Kim <namhyung@xxxxxxxxxx>
Reviewed-by: James Clark <james.clark@xxxxxxxxxx>

Thanks,
Ian