Re: [PATCH] kdb: use kmap_local_page()
From: Doug Anderson
Date: Fri Dec 20 2024 - 16:20:37 EST
Hi,
On Fri, Dec 20, 2024 at 2:25 AM zhangheng <zhangheng@xxxxxxxxxx> wrote:
>
> Use kmap_local_page() instead of kmap_atomic() which has been deprecated.
>
> Signed-off-by: zhangheng <zhangheng@xxxxxxxxxx>
nit: The fact that the "name" part of this is in all lowercase and
matches your email address makes me think you're lacking the "name"
part of your git config. Is "zhangheng" how you normally identify
yourself, or should there be spaces / capitalization? An Internet
search makes me think maybe this should be "Zhang Heng" ?
> ---
> kernel/debug/kdb/kdb_support.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I wasn't up on the whole kmap_atomic() deprecation, but LWN to the
rescue [1]. With that context, this looks fine to me.
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
[1] https://lwn.net/Articles/836144/