Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic

[Jakub Kicinski]

On Thu, 19 Dec 2024 11:21:55 +0200 Gur Stavi wrote:
> +config HINIC3
> +	tristate "Huawei Intelligent Network Interface Card 3rd"
> +	# Fields of HW and management structures are little endian and will not
> +	# be explicitly converted

This is a PCIe device, users may plug it into any platform.
Please annotate the endian of the data structures and use appropriate
conversion helpers.

> +	depends on 64BIT && !CPU_BIG_ENDIAN
> +	depends on PCI_MSI && (X86 || ARM64)

Also allow COMPILE_TEST

> +	help
> +	  This driver supports HiNIC PCIE Ethernet cards.
> +	  To compile this driver as part of the kernel, choose Y here.
> +	  If unsure, choose N.
> +	  The default is N.
-- 
pw-bot: cr