fs/gfs2/glock.c:1213: warning: Function parameter or struct member 'ip' not described in '__gfs2_holder_init'

From: kernel test robot
Date: Sat Dec 21 2024 - 07:26:44 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 499551201b5f4fd3c0618a3e95e3d0d15ea18f31
commit: b016d9a84abdd2efaa273814eaeb59e112ecffbd gfs2: Save ip from gfs2_glock_nq_init
date: 3 years, 2 months ago
config: arm64-randconfig-003-20241220 (https://download.01.org/0day-ci/archive/20241221/202412212036.wYxgeNuQ-lkp@xxxxxxxxx/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 9daf10ff8f29ba3a88a105aaa9d2379c21b77d35)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241221/202412212036.wYxgeNuQ-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412212036.wYxgeNuQ-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> fs/gfs2/glock.c:1213: warning: Function parameter or struct member 'ip' not described in '__gfs2_holder_init'
fs/gfs2/glock.c:1213: warning: expecting prototype for gfs2_holder_init(). Prototype was for __gfs2_holder_init() instead


vim +1213 fs/gfs2/glock.c

b3b94faa5fe596 David Teigland 2006-01-16 1201
b3b94faa5fe596 David Teigland 2006-01-16 1202 /**
b3b94faa5fe596 David Teigland 2006-01-16 1203 * gfs2_holder_init - initialize a struct gfs2_holder in the default way
b3b94faa5fe596 David Teigland 2006-01-16 1204 * @gl: the glock
b3b94faa5fe596 David Teigland 2006-01-16 1205 * @state: the state we're requesting
b3b94faa5fe596 David Teigland 2006-01-16 1206 * @flags: the modifier flags
b3b94faa5fe596 David Teigland 2006-01-16 1207 * @gh: the holder structure
b3b94faa5fe596 David Teigland 2006-01-16 1208 *
b3b94faa5fe596 David Teigland 2006-01-16 1209 */
b3b94faa5fe596 David Teigland 2006-01-16 1210
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30 1211 void __gfs2_holder_init(struct gfs2_glock *gl, unsigned int state, u16 flags,
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30 1212 struct gfs2_holder *gh, unsigned long ip)
b3b94faa5fe596 David Teigland 2006-01-16 @1213 {
b3b94faa5fe596 David Teigland 2006-01-16 1214 INIT_LIST_HEAD(&gh->gh_list);
b3b94faa5fe596 David Teigland 2006-01-16 1215 gh->gh_gl = gl;
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30 1216 gh->gh_ip = ip;
b1e058da50f793 Pavel Emelyanov 2008-02-07 1217 gh->gh_owner_pid = get_pid(task_pid(current));
b3b94faa5fe596 David Teigland 2006-01-16 1218 gh->gh_state = state;
b3b94faa5fe596 David Teigland 2006-01-16 1219 gh->gh_flags = flags;
b3b94faa5fe596 David Teigland 2006-01-16 1220 gh->gh_error = 0;
b3b94faa5fe596 David Teigland 2006-01-16 1221 gh->gh_iflags = 0;
b3b94faa5fe596 David Teigland 2006-01-16 1222 gfs2_glock_hold(gl);
b3b94faa5fe596 David Teigland 2006-01-16 1223 }
b3b94faa5fe596 David Teigland 2006-01-16 1224

:::::: The code at line 1213 was first introduced by commit
:::::: b3b94faa5fe5968827ba0640ee9fba4b3e7f736e [GFS2] The core of GFS2

:::::: TO: David Teigland <teigland@xxxxxxxxxx>
:::::: CC: Steven Whitehouse <swhiteho@xxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki